Qpid Proton
  1. Qpid Proton
  2. PROTON-242

Shared library used JNI code has poor name "libproton-swig.so"

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.4
    • Component/s: proton-c
    • Labels:
      None

      Description

      The shared library used JNI code has name "libproton-swig.so", which is poor because the (a) it doesn't hint that it's used by the proton-jni.jar, and (b) Swig should be an implementation detail that is hidden from the user of the library.

      A better name would be "libproton-jni.so".

      Note that I've used the "lib" prefix as required by JNI on Linux. On Windows, this prefix should be blank.

        Activity

        Hide
        Keith Wall added a comment -

        Output name of the shared object has been renamed from proton-swig to proton-jni. This mirrors the name of its companion JAR proton-jni.jar. The lib prefix and suffix will reflect the convenions of the build machines (lib prefix, so suffix on unix etc).

        Show
        Keith Wall added a comment - Output name of the shared object has been renamed from proton-swig to proton-jni. This mirrors the name of its companion JAR proton-jni.jar. The lib prefix and suffix will reflect the convenions of the build machines (lib prefix, so suffix on unix etc).

          People

          • Assignee:
            Keith Wall
            Reporter:
            Philip Harvey
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development