[PROTON-2380] frame tracing issues/improvements

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: protonj2-1.0.0-M1
• Fix Version/s: protonj2-1.0.0-M2
• Component/s: protonj2
• Assignee: Timothy A. Bish
• Reporter: Robbie Gemmell
• Created: 06/May/21 11:57
• Updated: 12/May/21 15:51
• Resolved: 12/May/21 15:51

Description

Running the HelloWorld example against Broker-J 8.0.4 with PN_TRACE_FRM=true style frame trace enabled shows some areas for improvement.

• Nothing distinguishes the connection it applies to (e.g in other cases we log include the memory address), limiting value in multi-connection use cases.
• The run ultimately resulted in exposing a broker bug (QPID-8523), causing connection closure with explanation, but the attach frame trace itself didnt show the issue at all, instead implying a value was sent (printing initialDeliveryCount=0). Some way of distinguishing actual vs default (in code terms) values received, and possibly how many fields were populated, would be useful.
• Some binary bits will just print out the buffer class/sizes etc.
• The initial SASL header is prefixed 'AMQP' which is debatable (both ways, since its only a header). May be simpler to say SASL to show transition. Or drop the prefix.