[PROTON-2377] [cpp] tag_counter is not used in a thread safe way in sender.cpp

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: proton-c-0.35.0
• Component/s: cpp-binding
• Assignee: Rakhi Kumari
• Reporter: Rakhi Kumari
• Created: 22/Apr/21 09:14
• Updated: 02/Jul/21 15:10
• Resolved: 11/May/21 16:46

Description

uint64_t tag_counter = 0 is a global variable, so it might end up giving duplicate ids to different threads.
We need to ensure that a single sender will not send a message with a duplicate tag. Thread safety is required to guarantee unique tags.

Link to the discussion regarding this issue :
https://github.com/apache/qpid-proton/pull/309#discussion_r615219442