[PROTON-2320] Apply autofixes to resolve some flake8 code formatting issues

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-c-0.33.0
• Fix Version/s: proton-c-0.34.0
• Component/s: python-binding
• Assignee: Jiri Daněk
• Reporter: Jiri Daněk
• Created: 14/Jan/21 04:58
• Updated: 12/Apr/21 08:35
• Resolved: 15/Jan/21 14:05

Description

Python code in Proton does not follow PEP8. There are automated tools which can reformat the code to be more compliant (fix indentation, add spaces around operators, ...).

pip install autopep8
for f in `find -name "*.py"`; do autopep8 --in-place $f; done

Autopep8 has several level of "aggressiveness". The least aggressive setting only changes whitespace. At a more aggressive setting, autopep8 will also rewrite some code constructs.

My plan is to commit this in several stages. Avoid mixing manual changes and automatically generated changes in a single commit. Push the whitespace changes first and only then let autopep8 to be more creative; otherwise the rewrites get drowned in the huge initial diff.

I don't want to add flake8 to CI jobs just yet; I want to wait a few days with that.

Issue Links

• is related to: PROTON-2322 Fix and remove ignores in flake8 configuration
• is related to: DISPATCH-1814 Apply autofixes to resolve some flake8 code formatting issues
• links to: Example of failed flake8 test