[PROTON-2224] Unexpected arguments in `log.warn` at python/setuputils/misc.py

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: proton-c-0.31.0
• Component/s: build, python-binding
• External issue URL: https://sonarcloud.io/project/issues?id=jiridanek_qpid-proton&issues=AXIejPpVFQeJzc94UjCH&open=AXIejPpVFQeJzc94UjCH
• Assignee: Unassigned
• Reporter: Jiri Daněk
• Created: 16/May/20 20:05
• Updated: 16/May/20 20:06

Description

python/setuputils/log.py

def warn(msg):
    logger.error("Warning: " + msg)

python/setuputils/misc.py

def pkg_config_get_var(package, name):
    """Retrieve the value of the named package variable as a string
    """
    p = _call_pkg_config(['--variable=%s' % name, package])
    if not p:
        log.warn("pkg-config: var %s get failed, package %s", name, package)

> Remove 2 unexpected arguments; 'warn' expects 1 positional arguments.Why is this an issue?
3 years ago L79 Bug Blocker Open Not assigned 10min effort
> Comment based-on-misra, cwe

        return ""

Forthermore, logger.warn in Python stdlib is now deprecated, so it might make sense to rename the function.