[PROTON-2223] Duplicated branch in ruby/lib/util/error_handler.rb

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: proton-c-0.31.0
• Component/s: ruby-binding
• External issue URL: https://sonarcloud.io/project/issues?id=jiridanek_qpid-proton&issues=AXIejPbxFQeJzc94Ui9p&open=AXIejPbxFQeJzc94Ui9p
• Assignee: Alan Conway
• Reporter: Jiri Daněk
• Created: 16/May/20 19:56
• Updated: 16/May/20 19:59

Description

        raise Qpid::Proton::StateError.new(self.error)
      when Qpid::Proton::Error::TIMEOUT
        raise Qpid::Proton::TimeoutError.new(self.error)
      when Qpid::Proton::Error::INPROGRESS
        return
      when Qpid::Proton::Error::INTERRUPTED
        raise Qpid::Proton::InterruptedError.new(self.error)
      when Qpid::Proton::Error::INPROGRESS

> This condition duplicates the one on line 87.Why is this an issue?
> 6 years ago L93 Bug Major Open Not assigned 10min effort
> Comment pitfall, unused

        raise Qpid::Proton::InProgressError.new(self.error)
      else
        raise ::ArgumentError.new("Unknown error code: #{co de}")
      end
    end

edit: lol, first time it happened to me that a code block in Jira contains "{code}" and breaks formatting.