[PROTON-2194] Incorrect memory deallocation

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: proton-c-0.31.0
• Assignee: Andrew Stitcher
• Reporter: Attila Kun
• Created: 15/Apr/20 19:50
• Updated: 14/May/20 09:30
• Resolved: 23/Apr/20 01:08

Description

When execution gets to server_name_matches in schannel.c, an attempt is made to deallocate a chunk of memory here: https://github.com/apache/qpid-proton/blob/0.30.0/c/src/ssl/schannel.c#L2078
However, this is incorrect because the code is passing the pointer's address (which is a memory location on the stack, not the heap) to LocalFree . This causes a crash. The fix is simply to pass the pointer's value: https://github.com/attila-kun/qpid-proton/commit/21e88fe0b18a4587768b16ae275a8ae88fd919bb

Issue Links

• links to: GitHub Pull Request #240