[PROTON-2143] Linkage warnings build proton-c/python bindings

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: proton-c-0.30.0
• Component/s: proton-c, python-binding
• Environment: Windows
• Assignee: Andrew Stitcher
• Reporter: Andrew Stitcher
• Created: 22/Nov/19 18:51
• Updated: 16/Dec/19 10:52
• Resolved: 22/Nov/19 19:01

Description

You get lots of warnings like:

D:\a\1\s\BLD\c\src\extra\url.c(191): warning C4273: 'pn_url': inconsistent dll linkage [D:\a\1\s\BLD\c\tests\fuzz\fuzz-url.vcxproj]
{{   D:\a\1\s\c\include\proton/url.h(47): note: see previous definition of 'pn_url'}}
{{ D:\a\1\s\BLD\c\src\extra\url.c(204): warning C4273: 'pn_url_parse': inconsistent dll linkage [D:\a\1\s\BLD\c\tests\fuzz\fuzz-url.vcxproj]}}
{{   D:\a\1\s\c\include\proton/url.h(68): note: see previous definition of 'pn_url_parse'}}
{{ D:\a\1\s\BLD\c\src\extra\url.c(223): warning C4273: 'pn_url_free': inconsistent dll linkage [D:\a\1\s\BLD\c\tests\fuzz\fuzz-url.vcxproj]}}
{{   D:\a\1\s\c\include\proton/url.h(74): note: see previous definition of 'pn_url_free'}}
{{ D:\a\1\s\BLD\c\src\extra\url.c(226): warning C4273: 'pn_url_clear': inconsistent dll linkage [D:\a\1\s\BLD\c\tests\fuzz\fuzz-url.vcxproj]}}
{{   D:\a\1\s\c\include\proton/url.h(80): note: see previous definition of 'pn_url_clear'}}
{{ D:\a\1\s\BLD\c\src\extra\url.c(237): warning C4273: 'pn_url_str': inconsistent dll linkage [D:\a\1\s\BLD\c\tests\fuzz\fuzz-url.vcxproj]}}
{{   D:\a\1\s\c\include\proton/url.h(89): note: see previous definition of 'pn_url_str'}}
{{ D:\a\1\s\BLD\c\src\extra\url.c(257): warning C4273: 'pn_url_get_scheme': inconsistent dll linkage [D:\a\1\s\BLD\c\tests\fuzz\fuzz-url.vcxproj]}}
{{   D:\a\1\s\c\include\proton/url.h(99): note: see previous definition of 'pn_url_get_scheme'}}
{{ D:\a\1\s\BLD\c\src\extra\url.c(258): warning C4273: 'pn_url_get_username': inconsistent dll linkage [D:\a\1\s\BLD\c\tests\fuzz\fuzz-url.vcxproj]}}
{{   D:\a\1\s\c\include\proton/url.h(101): note: see previous definition of 'pn_url_get_username'}}
{{ D:\a\1\s\BLD\c\src\extra\url.c(259): warning C4273: 'pn_url_get_password': inconsistent dll linkage [D:\a\1\s\BLD\c\tests\fuzz\fuzz-url.vcxproj]}}
{{   D:\a\1\s\c\include\proton/url.h(103): note: see previous definition of 'pn_url_get_password'}}
{{ ...}}

These are due to building statically without setting the correct build flags.