[PROTON-2115] Bitrot in qpid-proton/c/tests/fdlimit.py

• Type: Test
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-c-0.29.0
• Fix Version/s: proton-c-0.30.0
• Component/s: proton-c
• Assignee: Jiri Daněk
• Reporter: Jiri Daněk
• Created: 03/Oct/19 14:18
• Updated: 16/Dec/19 10:52
• Resolved: 13/Nov/19 18:41

Description

Originally, Proc was imported in scope, https://github.com/apache/qpid-proton/commit/087b94faef6f0bc3fc2eac50ba0d2c2b03d82fbd#diff-9ad88150e74c307cdd1f621348dca9d6R20

Nowadays, it isn't, current state of the file is this https://github.com/apache/qpid-proton/blob/9778eda8e9387caa8a207fbb6fedfa09ac0e298a/c/tests/fdlimit.py#L41

# Check if we can run prlimit to control resources
try:
    Proc(["prlimit"]).wait_exit()
except:
    print("Skipping test: prlimit not available")
    sys.exit(0)

The broad except masks the error here, and also anything else in the rest of the file (which is never executed).

Issue Links

• links to: GitHub Pull Request #198
• links to: GitHub Pull Request #205
• links to: GitHub Pull Request #220