[PROTON-2091] [python] example broker never removes empty queues

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: proton-c-0.29.0
• Fix Version/s: proton-c-0.30.0
• Component/s: python-binding
• Flags: Patch
• Assignee: Jiri Daněk
• Reporter: Jiri Daněk
• Created: 23/Aug/19 21:25
• Updated: 16/Dec/19 10:52
• Resolved: 24/Aug/19 07:49

Description

    def unsubscribe(self, consumer):
         if consumer in self.consumers:
            self.consumers.remove(consumer)
         return len(self.consumers) == 0 and (self.dynamic or self.queue.count == 0)

Here, self.queue.count == 0 can never be True (because method reference != integer). This means that broker will never drop the Queue object.

Functionality wise, the impact of this is insignificant, given the uses of the code (stand-in for real broker when running simple messaging examples).

It has compatibility implications, however, because self.queue.count is a Python 2.7 addition and on Python 2.6 accessing undefined property will raise exception and crash the broker.

Issue Links

• links to: GitHub Pull Request #188