[PROTON-2010] [python] JSON connection config: comments and SASL mechs don't work

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-c-0.27.0
• Fix Version/s: proton-c-0.27.1
• Component/s: python-binding
• Assignee: Kim van der Riet
• Reporter: Kim van der Riet
• Created: 26/Feb/19 16:52
• Updated: 23/Apr/19 11:05
• Resolved: 11/Apr/19 16:39

Description

If the JSON connection config file contains C/C++-style comments, or a list of SASL mechanisms, then the client errors.

The JSON specification does not allow for comments. However, the connection config file specifies that c/c++ comments may be embedded within the JSON. A comment eliminator needs to be used before the JSON is loaded.

The call to pn_sasl_allowed_mechs() requires a const char* space-separated list of SASL mechs. The python does not correctly handle this case, as it is passing the mechs as a Python list of strings. A single string containing a mech instead of a list in the JSON should also be handled.