[PROTON-1938] misaligned Transport set/getErrorCondition and closed() behaviour

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: proton-j-0.29.0
• Fix Version/s: proton-j-0.30.0
• Component/s: proton-j
• Assignee: Robbie Gemmell
• Reporter: Sreeram Garlapati
• Created: 20/Sep/18 22:07
• Updated: 09/Nov/18 17:43
• Resolved: 30/Oct/18 15:01

Description

Although at various places in proton library - transport.setCondition() was invoked (for ex: IOHandler.java - invokes several places to communicate socket IOExceptions) - this was overwritten in TransportImpl.closed method and shows up as - ConnectionError.FRAMING_ERROR.

I created this PR: to help easily identify - where the problem was: https://github.com/apache/qpid-proton-j/pull/16

Please let me know if you need more info or have any inputs finishing the PR at [e-mail]...

Issue Links

• links to: GitHub Pull Request #16