[PROTON-1758] [Python binding] Check message application property keys, convert binary to string

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: proton-c-0.21.0
• Component/s: python-binding
• Assignee: Kim van der Riet
• Reporter: Kim van der Riet
• Created: 02/Feb/18 20:10
• Updated: 26/Mar/18 10:20
• Resolved: 02/Feb/18 21:55

Description

The AMQP 1.0 specification requires message application property keys to be strings. Currently the Python binding makes no type check on message application property key types. Under Python 2, using the pattern

props['key'] = 'value'

results in the key being encoded as binary, whereas in Python 3, it is a unicode string. While changing the pattern to

props[u'key'] = u'value'

is trivially easy and would work for both versions of Python, it would help usability and AMQP wire correctness if the binding would check the key type and:

1. if binary, convert to unicode string;
2. if any other type, raise an exception

before sending a message.