[PROTON-1757] pn_netaddr_host_port() fails on FreeBSD

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-c-0.20.0
• Fix Version/s: proton-c-0.21.0
• Component/s: proton-c
• Assignee: Andrew Stitcher
• Reporter: Andrew Stitcher
• Created: 01/Feb/18 02:32
• Updated: 26/Mar/18 10:20
• Resolved: 01/Feb/18 22:42

Description

Many tests fail when building/testing on recent FreeBSD (10 and 11).

Ultimately this is due to the FreeBSD getnameinfo insisting that the passed in socklen is the exact correct value for the sa_family. Whereas the pn_netaddr_socklen code unconditionally says the length is the sizeof sockaddr_storage - this is rejected by this implementation of getnameinfo.

It's not clear that this is the correct behaviour of getnameinfo, but it's easy enough to allow for.