[PROTON-1739] remove confusing default for session capacity and allow disabling it

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: proton-j-0.24.0
• Fix Version/s: proton-j-0.25.0
• Component/s: proton-j
• Assignee: Robbie Gemmell
• Reporter: Robbie Gemmell
• Created: 10/Jan/18 17:59
• Updated: 11/Apr/18 10:36
• Resolved: 11/Jan/18 15:57

Description

The session has a default 'incoming capacity' of 1MB, which actually has no effect by default and leads to unexpected behaviour while changing other configuration. It should be removed.

The value is used when the engine decides what incoming session window to set on Flow frames, but only if a specific frame size is configured for the transport, which it isn't by default. If a specific frame size is set, then any session capacity really needs to be set based on it in order to be appropriate, the default being fixed as it is leads to unexpectedly low window sizes in many cases which will impact performance in unexpected ways. Its confusing that setting frame size results in completely different behaviour than before for another thing (window size) which perhaps hasn't been configured at all, and the existing behaviour is also such that you cant turn it off.

Issue Links

• relates to: PROTON-636 remove confusing default for session capacity and allow disabling it