[PROTON-1384] the 'Data' utility incorrectly encodes str32 type length

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-j-0.17.0
• Fix Version/s: proton-j-0.18.0
• Component/s: proton-j
• Assignee: Robbie Gemmell
• Reporter: Robbie Gemmell
• Created: 06/Jan/17 11:46
• Updated: 16/May/17 14:15
• Resolved: 07/Mar/17 11:36

Description

The 'Data' utility incorrectly encodes str32 type, due to a (probable c&p) error in StringElement, it encodes the length as a [u]byte when it should be a [u]int.

Something like below should fix things (will make it after the reorg is done, and I add a test):

@@ -127,7 +127,7 @@ class StringElement extends AtomicElement<String>
         else
         {
             b.put((byte)0xb1);
-            b.put((byte)length);
+            b.putInt(length);
         }
         b.put(bytes);
         return size;