[PROTON-1376] [C, windows] Release 0.16 build fail - src/protocol.h clobbered

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-0.16.0
• Fix Version/s: proton-c-0.17.0
• Component/s: proton-c
• Environment: Visual Studio 2012, x64
• Assignee: Unassigned
• Reporter: Charles E. Rolke
• Created: 13/Dec/16 15:29
• Updated: 08/Feb/17 18:59
• Resolved: 21/Dec/16 14:34

Description

Target generated_c_files builds the src/protocol.h and src/encodings.h files.
Then projects qpid-proton and qpid-proton-core depend on generated_c_files.

It appears that generated_c_files as a dependency does not respect existing src/protocol.h and src/encodings.h files and generates them three times in total.

On a four-core build system the files are created three times but well before other build threads try to use them. On other systems the timing is such that a compilation of codec.c needs protocol.h but it is erased by the third file creation.

2>------ Build started: Project: generated_c_files, Configuration: Debug x64 ------
2>Build started 12/12/2016 4:49:28 PM.
2>CustomBuild:
2>  Building Custom Rule P:/qpid-proton/proton-c/CMakeLists.txt
2>  CMake does not need to re-run because P:\qpid-proton\build\proton-c\CMakeFiles\generate.stamp is up-to-date.
2>  Generating src/protocol.h
2>  Generating src/encodings.h
2>
2>Build succeeded.

3>------ Build started: Project: qpid-proton, Configuration: Debug x64 ------
4>------ Build started: Project: qpid-proton-core, Configuration: Debug x64 ------
3>  Building Custom Rule P:/qpid-proton/proton-c/CMakeLists.txt
3>  CMake does not need to re-run because P:\qpid-proton\build\proton-c\CMakeFiles\generate.stamp is up-to-date.
3>  Generating src/encodings.h
3>  Generating src/protocol.h
3>ClCompile:
3>  object.c
3>  list.c
3>  map.c
3>  string.c
3>  iterator.c
4>Build started 12/12/2016 4:49:29 PM.
3>  record.c
3>  log.c
3>  util.c
3>  error.c
3>  buffer.c
4>CustomBuild:
4>  Building Custom Rule P:/qpid-proton/proton-c/CMakeLists.txt
3>  types.c
4>  CMake does not need to re-run because P:\qpid-proton\build\proton-c\CMakeFiles\generate.stamp is up-to-date.
4>  Generating src/encodings.h
3>  framing.c
3>  codec.c
4>  Generating src/protocol.h
3>..\..\proton-c\src\core\codec.c(33): fatal error C1083: Cannot open include file: 'protocol.h': No such file or directory