[PROTON-1336] [Proton-c 0.14.0][Visual Studio 2013] Failing ssl unit test only in Debug mode

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-0.14.0
• Fix Version/s: proton-0.16.0
• Component/s: proton-c
• Labels: patch windows
• Assignee: Clifford Jansen
• Reporter: Adel Boutros
• Created: 28/Oct/16 14:06
• Updated: 13/Dec/16 18:53
• Resolved: 01/Dec/16 21:06

Description

check full details here: http://qpid.2158936.n2.nabble.com/Proton-c-0-14-0-Visual-Studio-2013-Failing-ssl-unit-test-only-in-Debug-mode-td7652076.html

Suggested patch by Cliff is tested and working

--- proton/proton-c/src/windows/io.c    2016-08-16 06:02:21 -0700 
+++ new/proton-c/src/windows/io.c    2016-10-19 16:19:21 -0700 
@@ -90,8 +90,11 @@ 
 void pn_io_finalize(void *obj) 
 { 
   pn_io_t *io = (pn_io_t *) obj; 
-  pn_error_free(io->error); 
+  pn_selector_t *sel = io->iocp->selector; 
   pn_free(io->iocp); 
+  if (sel) 
+    pn_decref(sel); 
+  pn_error_free(io->error); 
   WSACleanup(); 
 } 

@@ -366,8 +369,10 @@ 

 pn_selector_t *pn_io_selector(pn_io_t *io) 
 { 
-  if (io->iocp->selector == NULL) 
+  if (io->iocp->selector == NULL) { 
     io->iocp->selector = pni_selector_create(io->iocp); 
+    pn_incref(io->iocp->selector); 
+  } 
   return io->iocp->selector; 
 } 

Issue Links

• relates to: PROTON-1340 [Visual Studio 2013] Event_loop injection triggers an exception when the container is being destroyed