[PROTON-1300] [proton-j] remove redundant credit update call

• Type: Task
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: proton-0.14.0
• Fix Version/s: proton-0.15.0
• Component/s: proton-j
• Assignee: Robbie Gemmell
• Reporter: Robbie Gemmell
• Created: 12/Sep/16 17:55
• Updated: 08/Feb/17 19:06
• Resolved: 12/Sep/16 18:00

Description

In TransportImpl.processSenderFlow() there is a redundant call to update the transportLink credit value to be 0 while draining the link,

transportLink.setLinkCredit(UnsignedInteger.valueOf(0));
transportLink.setDeliveryCount(transportLink.getDeliveryCount().add(credits));
transportLink.setLinkCredit(UnsignedInteger.ZERO);

These methods have no side effects, just simple setters/getters, and the same value is set twice, so this change just avoids it looking odd.

Credit tabish121 for spotting it