[PROTON-1256] Proton-c is very lax about allowing amqp and ssl protocol layers

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-0.13.1
• Fix Version/s: proton-0.14.0
• Component/s: proton-c
• Assignee: Andrew Stitcher
• Reporter: Andrew Stitcher
• Created: 14/Jul/16 14:54
• Updated: 01/Sep/16 10:05
• Resolved: 14/Jul/16 19:46

Description

The protocol auto detection code which is used when the proton-c transport is in server mode does not verify that the sequence of protocol layers it allows makes sense.

For instance it would recognise an AMQP_SASL header and process the layer and then allow any other layer to follow that even another AMQP_SASL layer.

As far as I know there are only a few legal sequences of protocol layers:

SSL; SASL; AMQP
SSL; AMQP
SASL; AMQP
SASL; AMQP_SSL; AMQP [Not sure if this is legal, seems to be]
AMQP_SSL; SASL; AMQP
AMQP_SSL; AMQP
AMQP

Any other sequence is non-sensical at best,