[PROTON-1243] Calling proton::container::stop() from within event handler causes infinite recursion

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-0.13.0
• Fix Version/s: proton-0.14.0
• Component/s: cpp-binding, proton-c
• Assignee: Andrew Stitcher
• Reporter: Andrew Stitcher
• Created: 21/Jun/16 17:54
• Updated: 01/Sep/16 10:05
• Resolved: 03/Aug/16 14:01

Description

There is current way to use proton::container::stop() or pn_reactor_stop() from within an event handler without causing infinite recursion.

Indeed there is even a note inside pn_reactor_stop():

...
// XXX: should consider removing this from stop to avoid reentrance
pn_reactor_process(reactor);
...

So I think there is no way to fix the issue in the current C++ implementation without removing the recursion somehow from the C code. However I don't know if doing this will cause a bug in some other circumstances!