[PROTON-1165] qpid proton cpp binding posix/io.cpp tests wrong error condition

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-0.12.0
• Fix Version/s: proton-0.14.0
• Component/s: cpp-binding
• Labels: patch
• Environment: linux/posix
• Assignee: Alan Conway
• Reporter: Roman Puls
• Created: 26/Mar/16 10:30
• Updated: 01/Sep/16 10:05
• Resolved: 19/Jul/16 15:38

Description

posix/io.cpp:

size_t socket_engine::io_write(const char *buf, size_t size) {
ssize_t n = ::write(socket_, buf, size);
if (n == EAGAIN || n == EWOULDBLOCK) return 0;
if (n < 0) check(n, "write: ");
return n;
}

instead of testing n against EAGAIN/EWOULDBLOCK, n needs to be tested against -1 and then errno needs to be compared to EAGAIN/EWOULDBLOCK

proposed fix:

size_t socket_engine::io_write(const char *buf, size_t size) {
ssize_t n = ::write(socket_, buf, size);

if (n < 0) {
if (errno == EAGAIN || errno == EWOULDBLOCK)

{ return 0; }

check(n, "write: ");
}
return n;
}