Uploaded image for project: 'MyFaces Portlet Bridge'
  1. MyFaces Portlet Bridge
  2. PORTLETBRIDGE-50

Should Bridge use Lifecycle to RestoreView when restoring from memory cache?

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.0.0-alpha
    • 1.0.0-beta, 2.0.0-alpha
    • Impl
    • None

    Description

      Currently the bridge manually restores the view in the first render after an action from memory (because the action can't save the view via faces). By manual I mean it merely sets the viewRoot to the view instead of calling Lifecycle.execute. This means the before/after restoreView phase listeners aren't called. About six months ago we added a hack to the spec/impl to require the before listener be called but withheld the after worried that running it twice in situation where action/render is usually in a single lifecycle could introduce problems. Well we hit use case where either neither of the two or both must be called but not one without the other (Faces demands this behavior).

      In discussing this it was raised that maybe we shouldn't have this manual process at all – instead restore the view from memory when necessary as a natural part of the RestoreView phase of executing the lifecycle.

      We decided we should try this and determine if there are any side effects.

      Attachments

        1. jira_50.patch
          6 kB
          Michael Freedman

        Activity

          People

            mike_freedman Michael Freedman
            mike_freedman Michael Freedman
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: