[PORTLETBRIDGE-187] Why does the 3.0.0 implementation of PortletFacesContextFactoryImpl differ from the one in 2.0?

• Type: Question
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 3.0.0-alpha
• Component/s: Impl
• Assignee: Michael Freedman
• Reporter: Hampus Wingren
• Created: 11/Mar/11 13:00
• Updated: 16/Mar/11 01:02

Description

This seems like an impossible thing to do if there is no other PortletFacesContext implementations available. Is it really correct to try and lookup another FacesContext if we are in a portlet environment?

// if in portlet environment – do a portlet container neutral test
// first in case we are packaged in a web app that isn't deployed
// on a portlet container/as a portlet. Note: can't use the BridgeUtil
// method as that call requires the facesContext to exist.
FacesContext fc = getWrapped().getFacesContext(context, request, response, lifecycle);

if(ExternalContextUtils.isPortlet(fc.getExternalContext()))

{ fc = new FacesContextImpl(fc); }

return fc;

regards,
Hampus