[POOL-63] [pool] Generic[Keyed]ObjectPool.ObjectTimestampPair can be static and can be shared

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.3

Environment

Operating System: All
Platform: All

• Bugzilla Id: 38649
• Assignee: Unassigned
• Reporter: Sandy McArthur (from Bugzilla import)
• Created: 15/Feb/06 15:24
• Updated: 12/Sep/10 17:42
• Resolved: 12/Sep/10 17:42

Description

The GenericObjectPools both have a package scoped inner class named
ObjectTimestampPair. This inner class can be static, which saves a reference
back to it's parent class and a very small bit of overhead. Once they are static
then the same implementation can be shared between the two GenericObjectPools.
This patch does just that. Since ObjectTimestampPair inner class is package
scoped this won't have any affect on API compatability.

FindBugs http://findbugs.sourceforge.net/ deserves credit for detecting that the
inner class could be static.