[POOL-376] invalidateObject should not return NullPointerException

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.6.1, 2.6.2, 2.7.0
• Fix Version/s: 2.8.0
• Labels: pull-request-available pull-requests-available
• Assignee: Unassigned
• Reporter: M Sazzadul Hoque
• Created: 21/Sep/19 06:58
• Updated: 15/Feb/20 05:49
• Resolved: 25/Sep/19 17:43

Description

GenericObjectPool.invalidateObject(T obj) should not return NullPointerException when obj is not null.

Please see following stack trace:

Caused by: java.lang.NullPointerException
        at org.apache.commons.pool2.impl.LinkedBlockingDeque.putLast(LinkedBlockingDeque.java:454)
        at org.apache.commons.pool2.impl.LinkedBlockingDeque.put(LinkedBlockingDeque.java:788)
        at org.apache.commons.pool2.impl.GenericObjectPool.destroy(GenericObjectPool.java:939)
        at org.apache.commons.pool2.impl.GenericObjectPool.invalidateObject(GenericObjectPool.java:618)

Apparent reason: In destroy(PooledObject<T> toDestroy), create() may return null even though toDestroy is already destroyed.

Please make the fix available for JDK 1.7.

Issue Links

• is broken by: POOL-356 deadlock if borrowObject gets called to fast and maxIdle is 0
• links to: #25
• links to: GitHub Pull Request #24