[POOL-306] BaseGenericObjectPool IdentityWrapper equals violates Java spec

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.4.2
• Fix Version/s: 2.4.3
• Flags: Patch
• Assignee: Unassigned
• Reporter: Anthony Whitford
• Created: 25/Oct/15 19:35
• Updated: 29/Oct/17 16:07
• Resolved: 15/Mar/16 14:34

Description

Noticed that the equals implementation assumes the other parameter can be successfully cast to IdentityWrapper:

        @Override
        @SuppressWarnings("rawtypes")
        public boolean equals(Object other) {
            return ((IdentityWrapper) other).instance == instance;
        }

(There is a chance that this could throw a ClassCastException.)

See BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS.

I recommend:

        @Override
        @SuppressWarnings("rawtypes")
        public boolean equals(Object other) {
            return other instanceof IdentityWrapper && ((IdentityWrapper) other).instance == instance;
        }