Uploaded image for project: 'Commons Pool'
  1. Commons Pool
  2. POOL-259

Client wait time is not updated when max wait is configured to be unlimited

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.3
    • Labels:
      None

      Description

      The local variable waitTime used by borrowObject in both GOP and GKOP is not updated unless borrowMaxWaitMillis is non-negative and blockWhenExhausted is true. This effectively zeros the JMX client wait time properties for these configurations. Even when there is a maxWait configured and the pool is set to block when exhausted, what ends up being reported is only the wait time on the instance queue. Note that this bug is JMX reporting only.

      I am inclined to fix this by setting waitTime at the beginning and updating it at the end (including activate and validate times). We should also add test cases for this and the other stats exposed via JMX. Patches welcome, as it may take me a little while to get to this.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              psteitz Phil Steitz
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: