Uploaded image for project: 'Commons Pool'
  1. Commons Pool
  2. POOL-244

[PATCH] Add more tests to [pool]

    XMLWordPrintableJSON

    Details

    • Type: Test
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1
    • Labels:

      Description

      Hi!

      I read a new version of [pool] was being prepared to be released and decided to chime in and add a few more tests.

      With these new tests, I believe the line coverage is above 70% is almost all the inner/classes but one that I thought wasn't worth writing more tests.

      In future dev cycles I hope to be able to increase the branch coverage to somewhere near 70% too, as well as fix some of the TODO tasks in the test code.

      I found a few trivial things that could be changed I think (typos, unreachable if's and naming inconsistencies) but I'll create separate issues for each one.

      Please, feel free to massage the code as much as needed or drop any parts if needed.

      Hope that helps,
      Bruno

        Attachments

        1. POOL-244.patch
          17 kB
          Bruno P. Kinoshita

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              kinow Bruno P. Kinoshita
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: