[POOL-24] [pool] Potential pool leak if _factory.makeObject() throws a Throwable

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2
• Fix Version/s: 1.3

Environment

Operating System: All
Platform: All

• Bugzilla Id: 34296
• Assignee: Unassigned
• Reporter: Denis Krylov
• Created: 05/Apr/05 14:01
• Updated: 12/Sep/10 17:42
• Resolved: 12/Sep/10 17:42

Description

The following code in GenericObjectPool.borrowObject is causing a
pool "leaking" in our system, when factory.makeObject throws a Throwable in the
following piece of code:

if(null == pair) {
try

{ Object obj = _factory.makeObject(); pair = new ObjectTimestampPair(obj); newlyCreated = true; }

catch (Exception e) {
// object cannot be created
synchronized(this)

{ _numActive--; notifyAll(); }

throw e;
}
}