[POOL-215] GenericKeyedObjectPool - multiple mutable fields not published safely

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0
• Assignee: Unassigned
• Reporter: Sebb
• Created: 27/Apr/12 13:20
• Updated: 31/Dec/14 16:25
• Resolved: 02/May/12 09:19

Description

The GenericKeyedObjectPool has multiple mutable instance fields that are neither volatile nor protected by syncronisation.
This means that updates by one thread may not be seen by other threads.

The following fields should either be made volatile, or be protected by a lock.
The lock is more suitable if the main usage is already protected by a lock.

blockWhenExhausted
evictionPolicy (getter and setter should use evictionLock)
lifo
maxIdlePerKey
maxTotal
maxTotalPerKey
maxWait
minEvictableIdleTimeMillis (getter and setter should use evictionLock)
numTestsPerEvictionRun (getter and setter should use evictionLock)
testWhileIdle (getter and setter should use evictionLock)
timeBetweenEvictionRunsMillis (getter and setter should use evictionLock)

Note that where the same fields appear in GOP, they are protected (apart from evictionPolicy, see POOL-214)