Uploaded image for project: 'Commons Pool'
  1. Commons Pool
  2. POOL-197

PooledObject: risky init of lastBorrowTime & lastReturnTime

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0
    • Labels:
      None

      Description

      PooledObject inits lastBorrowTime & lastReturnTime (and createTime) using System.currentTimeMillis().

      As well as being wasteful to call the System method 3 times, it's possible that the clock will change between invocations.
      This could result in getActiveTimeMillis() returning non-zero active time even though the object has never been used.

      Should probably init lastBorrowTime & lastReturnTime from createTime.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              sebb Sebb

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment