[POOL-188] Confusing PoolUtils.ErodingKeyedObjectPool.numIdle(K key) method; bug in ErodingKeyedObjectPool.returnObject(K key, V obj) ?

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0
• Fix Version/s: 2.0
• Assignee: Mark Thomas
• Reporter: Sebb
• Created: 11/May/11 12:16
• Updated: 31/Dec/14 16:16
• Resolved: 21/May/11 22:15

Description

numIdle(key) is equivalent to PoolUtils.ErodingKeyedObjectPool.getNumIdle() - unless the method getKeyedPool() is overridden.

It's confusing that the key parameter is not used - this may be the cause of a bug, as the method is used internally by ErodingKeyedObjectPool.returnObject(K key, V obj).

It looks like returnObject() should probably call getNumIdle(key) rather than numIdle(key).
In which case the confusing numIdle method can be deleted.