[POOL-133] Failed object creation may result in invalid active count in GKOP

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4
• Fix Version/s: 1.5
• Assignee: Mark Thomas
• Reporter: Mark Thomas
• Created: 17/Mar/09 21:09
• Updated: 19/Jun/09 16:12
• Resolved: 17/Mar/09 21:14

Description

In GenericKeyedObjectPool.borrowObject() there are two instances of:

try {
_factory.destroyObject(key,pair.value);
synchronized (this)

{ pool.decrementActiveCount(); }

} catch (Exception e2)

{ // swallowed }

The decrementing of the active count should be moved to a finally block to ensure that it is always called even if destroyObject() throws an exception.

I think this is what DCP-34 is getting at.