[POOL-105] how it go in method evict() of class GenericKeyedObjectPool.java

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Duplicate
• Affects Version/s: 1.3
• Fix Version/s: 1.4

Environment

windows

• Assignee: Unassigned
• Reporter: yigemaser
• Created: 27/Sep/07 21:41
• Updated: 05/May/12 22:33
• Resolved: 05/May/12 22:33

Description

in the method evict(), if the getNumTests() get 10,the key will not change , is it a problem??

public synchronized void evict() throws Exception {
Object key = null;
...............
for(int i=0,m=getNumTests();i<m;i++) {
System.out.println("key="+key);
if(_poolMap.size() > 0) {
// Find next idle object pool key to work on
if (key == null) {
if (!keyIter.hasNext())

{ _recentlyEvictedKeys.clear(); remainingKeys = new HashSet(_poolMap.keySet()); keyIter = remainingKeys.iterator(); }
if (!keyIter.hasNext()) { // done, there are no keyed pools return; }
key = keyIter.next();
}
...................
}
}
}
the print out will repeat 9 times , is it right??

i think this should move " key = keyIter.next();" to next line
if (key == null) {
if (!keyIter.hasNext()) { _recentlyEvictedKeys.clear(); remainingKeys = new HashSet(_poolMap.keySet()); keyIter = remainingKeys.iterator(); }

if (!keyIter.hasNext())

{ // done, there are no keyed pools return; }

}
key = keyIter.next();
......................

Issue Links

• duplicates: POOL-86 GenericKeyedObjectPool retaining too many idle objects