Major Description
Steps to reproduce:
1) deploy the tck V2RequestTests war
2) run Pluto in a debugger
3) set a break point in the processAction method for the V2RequestTests_ClientDataRequest_ApiAction_getPortletInputStream2 test case to see which method throws the exception (line 132 in master as of this post)
4) run the V2RequestTests_ClientDataRequest_ApiAction_getPortletInputStream2 test
5) step over each method call to see which one throws the IllegalStateException
Expected results:
- getPortletInputStream should be the method that throws an IllegalStateException and the test should pass for that reason on Pluto.
- the first call to getReader throws an IllegalStateException causing the test to pass on Pluto for the wrong reason.
Also, if you look at the V2RequestTests_ClientDataRequest_ApiAction_getReader2 test case in the processAction method, it should call getPortletInputStream first, and then call getReader second, and only then throw an IllegalStateException, but there is no call to getReader at all in the test see lines 249 thru 264 as of this post
Yet, the V2RequestTests_ClientDataRequest_ApiAction_getReader2 also passes on Pluto when it throws an IllegalStateException after simply calling getPortletInputStream, again never calling getReader as it should.
The main issue with both of these tests is that an IllegalStateException will always be thrown by either getReader or getPortletInputStream when the enctype of the submitted form is application/x-www-form-urlencoded, which is the default for tests in the TCK as of now.
Please look for my suggested fix for these tests below.