[PLUTO-616] maven-pluto-plugin logs an exception but doesn't fail the build on a malformed web.xml file

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Cannot Reproduce
• Fix Version/s: 2.0.4, 2.1.0, 3.0.0
• Component/s: maven pluto plugin
• Assignee: Eric Dalquist
• Reporter: Eric Dalquist
• Created: 15/Aug/12 14:38
• Updated: 04/Jan/17 12:33
• Resolved: 04/Jan/17 12:33

Description

maven-pluto-plugin logs an exception but doesn't fail the build on a malformed web.xml file

build	15-Aug-2012 09:35:37	[artifact:mvn] [INFO] --- maven-pluto-plugin:2.1.0-M2:assemble (default) @ uportal-war ---
build	15-Aug-2012 09:35:37	[artifact:mvn] [Fatal Error] :36:7: The element type "web-app" must be terminated by the matching end-tag "</web-app>".
build	15-Aug-2012 09:35:37	[artifact:mvn] [INFO] Reading web.xml from :/home/bamboo/bamboo-agent-home/xml-data/build-dir/UP-LIVEBUILD-JOB1/assembly/target/uPortal-live-nightly/uPortal-4.1.0-SNAPSHOT/uportal-war/src/main/webapp/WEB-INF/web.xml
build	15-Aug-2012 09:35:37	[artifact:mvn] [INFO] Reading portlet.xml from: /home/bamboo/bamboo-agent-home/xml-data/build-dir/UP-LIVEBUILD-JOB1/assembly/target/uPortal-live-nightly/uPortal-4.1.0-SNAPSHOT/uportal-war/src/main/webapp/WEB-INF/portlet.xml
build	15-Aug-2012 09:35:37	[artifact:mvn] [INFO] Writing web.xml to: /home/bamboo/bamboo-agent-home/xml-data/build-dir/UP-LIVEBUILD-JOB1/assembly/target/uPortal-live-nightly/uPortal-4.1.0-SNAPSHOT/uportal-war/target/pluto-resources/web.xml
build	15-Aug-2012 09:35:37	[artifact:mvn] [ERROR] Assembly failed: The element type "web-app" must be terminated by the matching end-tag "</web-app>".
build	15-Aug-2012 09:35:37	[artifact:mvn] org.apache.pluto.util.UtilityException: The element type "web-app" must be terminated by the matching end-tag "</web-app>".
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at org.apache.pluto.util.assemble.file.FileAssembler.assemble(FileAssembler.java:77)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at org.apache.pluto.maven.AssembleMojo.doExecute(AssembleMojo.java:186)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at org.apache.pluto.maven.AbstractPlutoMojo.execute(AbstractPlutoMojo.java:47)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at java.lang.reflect.Method.invoke(Method.java:597)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at org.codehaus.classworlds.Launcher.main(Launcher.java:47)
build	15-Aug-2012 09:35:37	[artifact:mvn] Caused by: java.io.IOException: The element type "web-app" must be terminated by the matching end-tag "</web-app>".
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at org.apache.pluto.util.assemble.io.WebXmlStreamingAssembly.assembleStream(WebXmlStreamingAssembly.java:67)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at org.apache.pluto.util.assemble.WebXmlRewritingAssembler.updateWebappDescriptor(WebXmlRewritingAssembler.java:51)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	at org.apache.pluto.util.assemble.file.FileAssembler.assemble(FileAssembler.java:74)
build	15-Aug-2012 09:35:37	[artifact:mvn] 	... 24 more