Pluto
  1. Pluto
  2. PLUTO-513

Support portlet managed custom modes as defined in PLT.8.4 of JSR-286 spec

    Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 2.0.0
    • Labels:
      None

      Description

      PLT.8.4 of the JSR-286 spec that defines portlet managed custom modes needs to be implemented in the Pluto container and portal driver.

      1. PLUTO-513_2.0-RefactoringPatch.txt
        29 kB
        Craig Doremus
      2. PortletManagedModes.jpg
        131 kB
        Craig Doremus

        Activity

        Craig Doremus created issue -
        Hide
        Craig Doremus added a comment -

        This is a screen shot from a solution I created in the 2.0-refactoring that I will be committing in the next few days.

        Show
        Craig Doremus added a comment - This is a screen shot from a solution I created in the 2.0-refactoring that I will be committing in the next few days.
        Craig Doremus made changes -
        Field Original Value New Value
        Attachment PortletManagedModes.jpg [ 12392649 ]
        Hide
        Craig Doremus added a comment -

        Patch file for 2.0-refactoring branch

        Show
        Craig Doremus added a comment - Patch file for 2.0-refactoring branch
        Craig Doremus made changes -
        Attachment PLUTO-513_2.0-RefactoringPatch.txt [ 12392692 ]
        Hide
        Craig Doremus added a comment - - edited

        Fix applied to 2.0-refactoring branch in SVN revs 707252, 707253 and 707265.

        Show
        Craig Doremus added a comment - - edited Fix applied to 2.0-refactoring branch in SVN revs 707252, 707253 and 707265.
        Craig Doremus made changes -
        Affects Version/s 2.0-refactoring [ 12313313 ]
        Craig Doremus made changes -
        Attachment PLUTO-513_2.0-RefactoringPatch.txt [ 12392692 ]
        Hide
        Craig Doremus added a comment -

        This patch is against the 2.0-refactoring branch that adds the pluto.tld that I missed in the previous patch.

        Show
        Craig Doremus added a comment - This patch is against the 2.0-refactoring branch that adds the pluto.tld that I missed in the previous patch.
        Craig Doremus made changes -
        Attachment PLUTO-513_2.0-RefactoringPatch.txt [ 12392693 ]
        Hide
        Ate Douma added a comment -

        Craig,

        Great feature: I like it.

        But... the current implementation (in PortletModeDropDownTag) has now broken the Admin portlets
        I've spend quite a lot of time trying to find out what was wrong and its still now 100% clear to me, but it has to do with the "anonymous" <form style="display:inline" ...> you emit from the tag for it.
        The Admin portlet uses and references its "adminForm", but together with the PortletModeDropDownTag this doesn't work anymore (document.forms['adminForm'] unknown).
        NB: I've been testing with Firefox 3.0 (Ubuntu).

        Can you please look into this?

        Show
        Ate Douma added a comment - Craig, Great feature: I like it. But... the current implementation (in PortletModeDropDownTag) has now broken the Admin portlets I've spend quite a lot of time trying to find out what was wrong and its still now 100% clear to me, but it has to do with the "anonymous" <form style="display:inline" ...> you emit from the tag for it. The Admin portlet uses and references its "adminForm", but together with the PortletModeDropDownTag this doesn't work anymore (document.forms ['adminForm'] unknown). NB: I've been testing with Firefox 3.0 (Ubuntu). Can you please look into this?
        Hide
        Craig Doremus added a comment -

        Fixed Admin Portlet that Ate noted above in PortletModeDropDownTag in SVN rev709647. Thanks for pointing this out. I will try to update the patch also with this fix.

        Show
        Craig Doremus added a comment - Fixed Admin Portlet that Ate noted above in PortletModeDropDownTag in SVN rev709647. Thanks for pointing this out. I will try to update the patch also with this fix.
        Craig Doremus made changes -
        Attachment PLUTO-513_2.0-RefactoringPatch.txt [ 12392693 ]
        Hide
        Craig Doremus added a comment -

        Updated to fix Admin Portlet problem Ate reported.

        Show
        Craig Doremus added a comment - Updated to fix Admin Portlet problem Ate reported.
        Craig Doremus made changes -
        Attachment PLUTO-513_2.0-RefactoringPatch.txt [ 12393186 ]
        Hide
        Craig Doremus added a comment -

        Fix in 2.0-refactoring branch moved to trunk.

        Show
        Craig Doremus added a comment - Fix in 2.0-refactoring branch moved to trunk.
        Craig Doremus made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Fix Version/s 2.0-refactoring [ 12313313 ]
        Hide
        Ate Douma added a comment -

        Not sure how the non portal managed modes (portlet managed modes) worked before the big refactoring but the portletcontainer currently doesn't allow it anymore.

        I'll adjust and optimize the current code checking which portlet modes are allowed and include checking for CustomPortletMode.isPortalManaged() == false.

        Show
        Ate Douma added a comment - Not sure how the non portal managed modes (portlet managed modes) worked before the big refactoring but the portletcontainer currently doesn't allow it anymore. I'll adjust and optimize the current code checking which portlet modes are allowed and include checking for CustomPortletMode.isPortalManaged() == false.
        Ate Douma made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Craig Doremus [ cdoremus ] Ate Douma [ adouma ]
        Hide
        Ate Douma added a comment -

        Fixed

        Show
        Ate Douma added a comment - Fixed
        Ate Douma made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Mark Thomas made changes -
        Workflow jira [ 12444480 ] Default workflow, editable Closed status [ 12565122 ]
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12565122 ] jira [ 12585879 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        15d 1h 41m 1 Craig Doremus 04/Nov/08 03:15
        Resolved Resolved Reopened Reopened
        171d 9h 33m 1 Ate Douma 24/Apr/09 13:49
        Reopened Reopened Resolved Resolved
        10m 39s 1 Ate Douma 24/Apr/09 14:00

          People

          • Assignee:
            Ate Douma
            Reporter:
            Craig Doremus
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development