Pluto
  1. Pluto
  2. PLUTO-501

Configuration errors are not much descriptive

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.7
    • Fix Version/s: 1.1.7
    • Component/s: general
    • Labels:
      None
    • Environment:

      Description

      Hi all,

      I was playing around with the project and found that sometimes is very difficult to trace down errors because missing configuration when deployment occurs.
      Also messages are not much descriptive and constructions like:

      PortletAppDD portletAppDD = PortletDescriptorRegistry.getRegistry().getPortletAppDD(servletContext);

      Makes tracing difficult to do.

      So I ask. Should we add a configurator or instructions ot configure the project?

      I mean, Where the files should be when deploying, Why files are found in classes directory and others in WEB-INF, while others in META-INF.

      I found particularly difficult the error with the file pluto-portal-driver-config.xml that was found in resources in maven and must be deployed to WEB-INF to let pluto find it.

      So I wrote some small patches that I include with this bug report to clarify some of the bugs, and let the user know what was wrong.

      I know this patch makes changes to the pom.xml of some subdirs, but they are needed to let m2eclipse plugin play fair.

      Thank you.

      1. config_patch_v2.diff
        16 kB
        Gonzalo Aguilar
      2. PLUTO-501_patch2.diff
        25 kB
        Craig Doremus

        Activity

        Hide
        Craig Doremus added a comment -

        Applied patches to 2.0-refactoring branch in SVN rev 702005.

        Show
        Craig Doremus added a comment - Applied patches to 2.0-refactoring branch in SVN rev 702005.
        Hide
        Craig Doremus added a comment -

        Modified affects and fixed version to reflect patch applied in SVN rev 701912.

        Show
        Craig Doremus added a comment - Modified affects and fixed version to reflect patch applied in SVN rev 701912.
        Hide
        Craig Doremus added a comment -

        I have applied PLUTO-501_patch2.diff in SVN rev 701912. This patch will have to be applied to the 2.0-refactoring branch. I think the 1.1.x branch would also benefit from these changes.

        Show
        Craig Doremus added a comment - I have applied PLUTO-501 _patch2.diff in SVN rev 701912. This patch will have to be applied to the 2.0-refactoring branch. I think the 1.1.x branch would also benefit from these changes.
        Hide
        Craig Doremus added a comment -

        I missed the pluto-portal-driver files in the last patch file. This is a replacement that includes that file and the other Java files from Gonzalo's original post. Thanks, again, for your help.

        Show
        Craig Doremus added a comment - I missed the pluto-portal-driver files in the last patch file. This is a replacement that includes that file and the other Java files from Gonzalo's original post. Thanks, again, for your help.
        Hide
        Craig Doremus added a comment -

        I took a look at Gonzalo's patch, removed all the extraneous files and modified a few other area that had poor logging and exception handling. I will commit this when I get a chance.

        Show
        Craig Doremus added a comment - I took a look at Gonzalo's patch, removed all the extraneous files and modified a few other area that had poor logging and exception handling. I will commit this when I get a chance.
        Hide
        Gonzalo Aguilar added a comment -

        Hi Craig,

        Yep sorry. I realized some of the patchs are not related after sending it. I have to do better job.

        Ok. I will separate the patch so only configuration error handling will go on it. Also some of the patch that does not change anything will be removed. I don't know why diff included them. I think I touched them without being conscience...

        Sorry to not doing it clean enough, my fault. Will not do again.

        Very thank's

        Show
        Gonzalo Aguilar added a comment - Hi Craig, Yep sorry. I realized some of the patchs are not related after sending it. I have to do better job. Ok. I will separate the patch so only configuration error handling will go on it. Also some of the patch that does not change anything will be removed. I don't know why diff included them. I think I touched them without being conscience... Sorry to not doing it clean enough, my fault. Will not do again. Very thank's
        Hide
        Craig Doremus added a comment -

        Thank you for your contribution Gonzalo. I agree that we need to do a better job reporting configuration errors, but some of the changes in your patch do not relate to this. Specifically, there are pom.xml modifications and a change to portlet.xml in the testsuite. Please add these these to separate Jira issues. Other parts of your patch do not change anything, in particular the modifications to logging.properties and web.xml just add whitespace to the files.

        Show
        Craig Doremus added a comment - Thank you for your contribution Gonzalo. I agree that we need to do a better job reporting configuration errors, but some of the changes in your patch do not relate to this. Specifically, there are pom.xml modifications and a change to portlet.xml in the testsuite. Please add these these to separate Jira issues. Other parts of your patch do not change anything, in particular the modifications to logging.properties and web.xml just add whitespace to the files.
        Hide
        Gonzalo Aguilar added a comment -

        This patch makes some errors more descriptive.

        Also this adds a message to the portlet window if the portlet cannot be loaded instead of the ugly trace of the error that can be seen in logs.

        Show
        Gonzalo Aguilar added a comment - This patch makes some errors more descriptive. Also this adds a message to the portlet window if the portlet cannot be loaded instead of the ugly trace of the error that can be seen in logs.

          People

          • Assignee:
            Craig Doremus
            Reporter:
            Gonzalo Aguilar
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 72h
              72h
              Remaining:
              Remaining Estimate - 72h
              72h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development