Pluto
  1. Pluto
  2. PLUTO-489

Refactor request attribute handling into optional service interface

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0-refactoring, 1.1.6, 2.0.0
    • Component/s: None
    • Labels:
      None

      Description

      To allow portal more control over request attribute processing and generation without having to re-implement the entire PortletRequest object model the request attribute handling methods in PortletRequest should delegate to an optional service interface.

        Activity

        Hide
        Eric Dalquist added a comment -

        This patch refactors the existing request attribute handling, including generation of the USER_INFO Map into an optional service. This patch is functionally identical and the only catch that upgrades may run into is if they implement OptionalContainerServices directly there is a new method RequestAttributeService getRequestAttributeService(); on the interface. Implementing the method is very easy and non-intrusive for portals using Pluto.

        Show
        Eric Dalquist added a comment - This patch refactors the existing request attribute handling, including generation of the USER_INFO Map into an optional service. This patch is functionally identical and the only catch that upgrades may run into is if they implement OptionalContainerServices directly there is a new method RequestAttributeService getRequestAttributeService(); on the interface. Implementing the method is very easy and non-intrusive for portals using Pluto.
        Hide
        Eric Dalquist added a comment -

        Patch against r678336 of the 2.0-spi-refactoring branch. I want to wait on feedback from Ate before committing these changes.

        Show
        Eric Dalquist added a comment - Patch against r678336 of the 2.0-spi-refactoring branch. I want to wait on feedback from Ate before committing these changes.
        Hide
        Eric Dalquist added a comment -

        This has been comitted to the trunk and the 1.1.patches branch. I am waiting on feedback from Ate before deciding on committing to the 2.0-spi-refactoring branch.

        Show
        Eric Dalquist added a comment - This has been comitted to the trunk and the 1.1.patches branch. I am waiting on feedback from Ate before deciding on committing to the 2.0-spi-refactoring branch.
        Hide
        Eric Dalquist added a comment -

        Applied to trunk, 1.1-patches and 2.0-refactoring

        Show
        Eric Dalquist added a comment - Applied to trunk, 1.1-patches and 2.0-refactoring

          People

          • Assignee:
            Eric Dalquist
            Reporter:
            Eric Dalquist
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development