[PLUTO-487] PortletPreferencesImpl should not store the preferences every time it is instantiated

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0-refactoring, 2.0.0
• Fix Version/s: 2.0-refactoring, 1.1.6, 2.0.0
• Component/s: portlet container
• Environment: Tomcat 5.5.26
• Assignee: Eric Dalquist
• Reporter: Nikita Dubrovsky
• Created: 14/May/08 21:50
• Updated: 23/Jul/08 14:05
• Resolved: 23/Jul/08 14:05

Description

In Pluto 1.1.5, the constructor of org.apache.pluto.internal.impl.PortletPreferencesImpl calls internalStore() every time. It would be better to only store the preferences when it is actually necessary – I believe this is the case only when the prefs from portlet.xml have not yet been stored:
...
Set portletXmlPrefNames = getPreferenceNames(defaultPreferences);
Set persistedPrefNames = getPreferenceNames(storedPreferences);
if (!persistedPrefNames.containsAll(portletXmlPrefNames))

{ internalStore(); }

...

private Set getPreferenceNames(InternalPortletPreference[] prefs) {
Set prefNames = new HashSet();
for (int i = 0; i < prefs.length; i++)

{ prefNames.add(prefs[i].getName()); }

return prefNames;
}