[PLUTO-484] PortletURLImpl.setSecure() throws PortletSecurityException when PortletURLProvider.isSecureSupported() returns true

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.5, 2.0-refactoring, 2.0.0
• Fix Version/s: 2.0-refactoring, 1.1.6, 2.0.0
• Component/s: portlet container
• Environment: Tomcat 5.5.26
• Assignee: Craig Doremus
• Reporter: Nikita Dubrovsky
• Created: 23/Apr/08 20:19
• Updated: 03/Aug/08 04:19
• Resolved: 03/Aug/08 04:19

Description

The method setSecure() on org.apache.pluto.internal.impl.PortletURLImpl is implemented as follows:

public void setSecure(boolean secure) throws PortletSecurityException {
PortletURLProvider urlProvider = container
.getRequiredContainerServices()
.getPortalCallbackService()
.getPortletURLProvider(servletRequest, internalPortletWindow);
if(urlProvider.isSecureSupported())

{ throw new PortletSecurityException("Secure URLs not supported."); }
}

The problem is that if the URL provider supports secure URLs, an exception is thrown. This code should be changed as follows:

public void setSecure(boolean secure) throws PortletSecurityException {
if(!secure) { return; }
PortletURLProvider urlProvider = container
.getRequiredContainerServices()
.getPortalCallbackService()
.getPortletURLProvider(servletRequest, internalPortletWindow);
if(urlProvider.isSecureSupported()) { urlProvider.setSecure(); } else { throw new PortletSecurityException("Secure URLs not supported."); }

}