Pluto
  1. Pluto
  2. PLUTO-477

PortletRequestImpl throws a NullPointerException when getting USER_INFO for unauthenticated users

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.5, 2.0.0
    • Fix Version/s: 1.1.6, 2.0.0
    • Component/s: portlet container
    • Labels:
      None

      Description

      PLT.17.2 states:
      If the request is done in the context of an un-authenticated user, calls to the getAttribute method of the request using the USER_INFO constant must return null.

      Currently the PortletRequestImpl.createUserInfoMap() does not handle the case of UserInfoService.getUserInfo returning null for an unauthenticated user and will throw a NullPointerException in this case.

        Activity

        Hide
        Eric Dalquist added a comment -

        Allow the UserInfoService to return a null map by short-circuting in PortletRequestImpl.createUserInfoMap() and returning null immediately when the UserInfoService returns null.
        Added unit test to verify fix
        Cleaned up javadocs on UserInfoService to more accurately describe the implementation contract.

        Show
        Eric Dalquist added a comment - Allow the UserInfoService to return a null map by short-circuting in PortletRequestImpl.createUserInfoMap() and returning null immediately when the UserInfoService returns null. Added unit test to verify fix Cleaned up javadocs on UserInfoService to more accurately describe the implementation contract.

          People

          • Assignee:
            Eric Dalquist
            Reporter:
            Eric Dalquist
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development