Pluto
  1. Pluto
  2. PLUTO-448

No way to know if expiration cache value was set via PortletDD

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.4
    • Fix Version/s: 1.1.5, 2.0.0
    • Component/s: descriptor
    • Labels:
      None

      Description

      The PortletDD object defaults the expirationCache property to 0. With this value there is no way to know if the expiration-cache element was specified in the portlet descriptor which is needed when implementing support for the expiration cache request property.

      Creating a EXPIRATION_CACHE_UNSET constant set to Integer.MIN_VALUE and initializing the expirationCache property in the PortletDD object with the constant provides a means for implementors to determine if the expiration-cache element was specified.

      1. pluto_cache.patch
        7 kB
        Eric Dalquist

        Activity

        Hide
        Eric Dalquist added a comment -

        Patch including test case for expiration cache property in PortletDD

        Show
        Eric Dalquist added a comment - Patch including test case for expiration cache property in PortletDD
        Hide
        Elliot Metsger added a comment -

        Fix committed to 1.1.x branch r599698.

        Show
        Elliot Metsger added a comment - Fix committed to 1.1.x branch r599698.
        Hide
        Elliot Metsger added a comment -

        Pending application to trunk.

        Show
        Elliot Metsger added a comment - Pending application to trunk.
        Hide
        Craig Doremus added a comment - - edited

        Added EXPIRATION_CACHE_UNSET expiration cache default in PortletDD to 1.1-286-trunk-merge branch in SVN rev 604630. Unit test was not added as it compiled with errors due to changes to that class in creating JSR-286 version of it..

        Show
        Craig Doremus added a comment - - edited Added EXPIRATION_CACHE_UNSET expiration cache default in PortletDD to 1.1-286-trunk-merge branch in SVN rev 604630. Unit test was not added as it compiled with errors due to changes to that class in creating JSR-286 version of it..
        Hide
        Elliot Metsger added a comment -

        Updated the test and committed it to trunk. Note that this patch really isn't needed in trunk since an ExpirationCacheDD has been added in 2.0. PortletDD.getExpirationCache() has been replaced by PortletDD.getExpirationCacheDD() and the method returns null if the portlet didn't specify an expiration cache.

        Show
        Elliot Metsger added a comment - Updated the test and committed it to trunk. Note that this patch really isn't needed in trunk since an ExpirationCacheDD has been added in 2.0. PortletDD.getExpirationCache() has been replaced by PortletDD.getExpirationCacheDD() and the method returns null if the portlet didn't specify an expiration cache.

          People

          • Assignee:
            Elliot Metsger
            Reporter:
            Eric Dalquist
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development