Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 2.0.0
    • Component/s: portlet container
    • Labels:
      None

      Description

      Merge this code with pluto-container module in SVN trunk.

      1. pluto-portal-driver-impl.urlfix.patch
        0.8 kB
        Benjamin Gould
      2. container_trunk_branch.patch
        303 kB
        Torsten Dettborn
      3. updateToRev26_container_fixes102307.patch
        472 kB
        Torsten Dettborn

        Activity

        Craig Doremus created issue -
        Craig Doremus made changes -
        Field Original Value New Value
        Affects Version/s 1.1-286-trunk-merge [ 12312669 ]
        Component/s portlet container [ 11203 ]
        Fix Version/s 1.1-286-trunk-merge [ 12312669 ]
        Description Merge this code with pluto-container module in SVN trunk.
        Hide
        Craig Doremus added a comment -

        SVN copied files from trunk that are not in the 1.1-286-COMPATIBILITY branch in SVN revisions 575266, 575267 and 575271. The following files will compile with errors:
        DefaultPortletEnvironmentService.java
        DefaultPortletInvokerService.java
        InternalPortletWindowImpl.java
        PortletInvocationEvent.java
        These errors will be fixed once the merge with the 1.1-286-COMPATIBILITY branch has been completed.

        Show
        Craig Doremus added a comment - SVN copied files from trunk that are not in the 1.1-286-COMPATIBILITY branch in SVN revisions 575266, 575267 and 575271. The following files will compile with errors: DefaultPortletEnvironmentService.java DefaultPortletInvokerService.java InternalPortletWindowImpl.java PortletInvocationEvent.java These errors will be fixed once the merge with the 1.1-286-COMPATIBILITY branch has been completed.
        Hide
        Torsten Dettborn added a comment -

        This patch fixes some bugs, so that pluto can be compiled. I would be happy, if anyone can take a look on it.

        Show
        Torsten Dettborn added a comment - This patch fixes some bugs, so that pluto can be compiled. I would be happy, if anyone can take a look on it.
        Torsten Dettborn made changes -
        Hide
        Craig Doremus added a comment -

        Thanks, Torsten.

        Can you commit this patch to the 1.1-286-COMPATIBILITY branch so we have one working branch with up-to-date JSR-286 changes?

        Show
        Craig Doremus added a comment - Thanks, Torsten. Can you commit this patch to the 1.1-286-COMPATIBILITY branch so we have one working branch with up-to-date JSR-286 changes?
        Hide
        Craig Doremus added a comment - - edited

        Applied part of updateToRev26_container_fixes102307.patch to portlet2-api module in SVN Revs 589118 and 589120.

        Show
        Craig Doremus added a comment - - edited Applied part of updateToRev26_container_fixes102307.patch to portlet2-api module in SVN Revs 589118 and 589120.
        Hide
        Craig Doremus added a comment - - edited

        Applied part of updateToRev26_container_fixes102307.patch to pluto-container module in SVN Revs 589127 and 589128.

        Show
        Craig Doremus added a comment - - edited Applied part of updateToRev26_container_fixes102307.patch to pluto-container module in SVN Revs 589127 and 589128.
        Hide
        Craig Doremus added a comment -

        Applied part of updateToRev26_container_fixes102307.patch to pluto-taglib and pluto-descriptor-api modules in SVN Rev 589129.

        Show
        Craig Doremus added a comment - Applied part of updateToRev26_container_fixes102307.patch to pluto-taglib and pluto-descriptor-api modules in SVN Rev 589129.
        Hide
        Craig Doremus added a comment - - edited

        Applied part of updateToRev26_container_fixes102307.patch to pluto-portal-driver-impl module in SVN Rev 589135. There may be other changes in PortalURLParserImpl that I have added since I am in the middle of merging pluto-portal-driver-impl with the trunk (see PLUTO-406).

        Now, everything in updateToRev26_container_fixes102307.patch has been applied to the 1.1-286-trunk-merge branch except for changes to PortalDriverServlet (in pluto-portal-driver module). That class will be applied with other changes to pluto-portal-driver when PLUTO-406 is addressed.

        Show
        Craig Doremus added a comment - - edited Applied part of updateToRev26_container_fixes102307.patch to pluto-portal-driver-impl module in SVN Rev 589135. There may be other changes in PortalURLParserImpl that I have added since I am in the middle of merging pluto-portal-driver-impl with the trunk (see PLUTO-406 ). Now, everything in updateToRev26_container_fixes102307.patch has been applied to the 1.1-286-trunk-merge branch except for changes to PortalDriverServlet (in pluto-portal-driver module). That class will be applied with other changes to pluto-portal-driver when PLUTO-406 is addressed.
        Hide
        Craig Doremus added a comment -

        Torsten, did you do any work in updateToRev26_container_fixes102307.patch to actually merge the pluto-container module into the trunk? If so, please specify what classes were merged. Or is this just an update to JSR-286 Rev 26?

        Show
        Craig Doremus added a comment - Torsten, did you do any work in updateToRev26_container_fixes102307.patch to actually merge the pluto-container module into the trunk? If so, please specify what classes were merged. Or is this just an update to JSR-286 Rev 26?
        Hide
        Craig Doremus added a comment -

        Added catch of PortletSecurityException to fix PortletURLProvider.setSecure() calls in PortletContainerImpl and BaseURLImpl in SVN rev 590627.

        Show
        Craig Doremus added a comment - Added catch of PortletSecurityException to fix PortletURLProvider.setSecure() calls in PortletContainerImpl and BaseURLImpl in SVN rev 590627.
        Hide
        Torsten Dettborn added a comment -

        I hope the merge for the container is complete, the following classes must deleted after merging is complete:

        internal/impl/PortletWindowImpl
        core/PortletInvoker
        spi/optional/UserInfoAttributesServiceImpl
        /src/test/java/org/apache/Pluto/spi/optional/UserInfoAttributesServicesImplTest

        the following files has been added:

        ClasspathScanner
        ContainerInvocationTest
        PortletContextManagerTest

        The following file has to configurate as it has been done in the trunk:

        src\main\resources\org\apache\pluto\environment.properties

        Show
        Torsten Dettborn added a comment - I hope the merge for the container is complete, the following classes must deleted after merging is complete: internal/impl/PortletWindowImpl core/PortletInvoker spi/optional/UserInfoAttributesServiceImpl /src/test/java/org/apache/Pluto/spi/optional/UserInfoAttributesServicesImplTest the following files has been added: ClasspathScanner ContainerInvocationTest PortletContextManagerTest The following file has to configurate as it has been done in the trunk: src\main\resources\org\apache\pluto\environment.properties
        Torsten Dettborn made changes -
        Attachment container_trunk_branch.patch [ 12368926 ]
        Hide
        Craig Doremus added a comment - - edited

        Applied container_trunk_branch.patch in SVN revs 592432 and 593821. There are compile errors in PortletContextManager and PortletContainerImpl. Please look at this Torsten.

        Show
        Craig Doremus added a comment - - edited Applied container_trunk_branch.patch in SVN revs 592432 and 593821. There are compile errors in PortletContextManager and PortletContainerImpl. Please look at this Torsten.
        Hide
        Craig Doremus added a comment -

        Modified PortletContextImpl with trunk changes to fix compile error in PortletContextManager in SVN rev 593883.

        Show
        Craig Doremus added a comment - Modified PortletContextImpl with trunk changes to fix compile error in PortletContextManager in SVN rev 593883.
        Hide
        Craig Doremus added a comment - - edited

        Here is a summary of activity over the last couple of days:

        1. Torsen applied a patch to fix the compile error in SVN rev 602095. The portal builds, but does not start up correctly.

        2. I modified InstallationDependency in maven-pluto-plugin to add ccpp.jar and castor.jar to Tomcat's shared/lib directory in SVN revs 602445 and 602455. The portal builds and starts, but all non-testsuite portlets error out. The testsuite portlet starts correctly, but links to the testsuite tests are not rendered.

        3. Modified AboutPortlet to add response.setContentType("text/html") to doView(), doEdit() and doHelp(), which is in conformance to PLT.12.3.1 of the JSR-168 spec. The portlet now renders correctly in the 1.2.0-286-SNAPSHOT portal. A small victory! This change was done in SVN rev 602523.

        Show
        Craig Doremus added a comment - - edited Here is a summary of activity over the last couple of days: 1. Torsen applied a patch to fix the compile error in SVN rev 602095. The portal builds, but does not start up correctly. 2. I modified InstallationDependency in maven-pluto-plugin to add ccpp.jar and castor.jar to Tomcat's shared/lib directory in SVN revs 602445 and 602455. The portal builds and starts, but all non-testsuite portlets error out. The testsuite portlet starts correctly, but links to the testsuite tests are not rendered. 3. Modified AboutPortlet to add response.setContentType("text/html") to doView(), doEdit() and doHelp(), which is in conformance to PLT.12.3.1 of the JSR-168 spec. The portlet now renders correctly in the 1.2.0-286-SNAPSHOT portal. A small victory! This change was done in SVN rev 602523.
        Hide
        Benjamin Gould added a comment -

        There is an errant import in the PortalCallbackServiceImpl. This is causing an instance of org.apache.pluto.core.driver.ResourceURLProviderImpl to be used instead of org.apache.pluto.driver.services.container.ResourceURLProviderImpl. Consequently, any portlet that attempts to generate a PortletURL is failing at the moment.

        This patch simply removes the import from PortalCallServiceImpl so that the correct implementation is used.

        Show
        Benjamin Gould added a comment - There is an errant import in the PortalCallbackServiceImpl. This is causing an instance of org.apache.pluto.core.driver.ResourceURLProviderImpl to be used instead of org.apache.pluto.driver.services.container.ResourceURLProviderImpl. Consequently, any portlet that attempts to generate a PortletURL is failing at the moment. This patch simply removes the import from PortalCallServiceImpl so that the correct implementation is used.
        Benjamin Gould made changes -
        Attachment pluto-portal-driver-impl.urlfix.patch [ 12371323 ]
        Hide
        Craig Doremus added a comment - - edited

        Applied pluto-portal-driver-impl.urlfix.patch and introduction_jsp.patch sent by Ben Gould to pluto-dev on 12/8/2007. in SVN rev 602887. Thank you Ben.

        The testsuite portlet now works in the 1.1-286-trunk-merge branch, but the following errors occur:

        Page: ExternalAppScopedAttributeTest
        Test: checkSetAppScopedAttributeHereSeenElsewhere
        Message: Click the provided link to validate test.

        Page: ExternalAppScopedAttributeTest
        Test: checkSetAppScopedAttributeElsewhereSeenHere
        Message: This test will not pass until you have opened the external resource using the link provided below.

        Page: SessionTimeoutTest
        Test: checkSessionInvalidated
        Message: Click the provided link to validate test.

        Page: MiscTest
        Test: checkContextMajorVersion
        Message: Assertion failed: got major version: 2, expected: 1

        Page: MiscTest
        Test: checkContextServerInfo
        Message: Error invoking checkContextServerInfo (java.lang.reflect.InvocationTargetException): null

        From what I remember, both of the ExternalAppScopedAttributeTest tests do not use a link to confirm the tests.

        Show
        Craig Doremus added a comment - - edited Applied pluto-portal-driver-impl.urlfix.patch and introduction_jsp.patch sent by Ben Gould to pluto-dev on 12/8/2007. in SVN rev 602887. Thank you Ben. The testsuite portlet now works in the 1.1-286-trunk-merge branch, but the following errors occur: Page: ExternalAppScopedAttributeTest Test: checkSetAppScopedAttributeHereSeenElsewhere Message: Click the provided link to validate test. Page: ExternalAppScopedAttributeTest Test: checkSetAppScopedAttributeElsewhereSeenHere Message: This test will not pass until you have opened the external resource using the link provided below. Page: SessionTimeoutTest Test: checkSessionInvalidated Message: Click the provided link to validate test. Page: MiscTest Test: checkContextMajorVersion Message: Assertion failed: got major version: 2, expected: 1 Page: MiscTest Test: checkContextServerInfo Message: Error invoking checkContextServerInfo (java.lang.reflect.InvocationTargetException): null From what I remember, both of the ExternalAppScopedAttributeTest tests do not use a link to confirm the tests.
        Hide
        Craig Doremus added a comment -

        This is no longer relevant since 286 code has now been merged into the Pluto trunk.

        Show
        Craig Doremus added a comment - This is no longer relevant since 286 code has now been merged into the Pluto trunk.
        Craig Doremus made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Closed [ 6 ]
        Mark Thomas made changes -
        Workflow jira [ 12410675 ] Default workflow, editable Closed status [ 12564867 ]
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12564867 ] jira [ 12586366 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Craig Doremus
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development