Pluto
  1. Pluto
  2. PLUTO-356

Pluto Driver not using injected Portal URL Parser

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.1.2, 1.1.4
    • Fix Version/s: 1.1.5
    • Component/s: portal driver
    • Labels:
      None

      Description

      Hi all,

      We are in the process of upgrading to pluto 1.1.2 and have run into a small problem. We have taken advantage of the new IoC to inject the required and optional services into our container services (ContainerServicesImpl). It appears that the PortalURLImpl and RelativePortalURLImpl classes in the driver are not using the injected override service for URL creation (PortalURLParser). The code below is showing the singleton access which always comes from org.apache.pluto.driver.url.impl rather than the container services.

      // The toString() method for both classes listed below

      org.apache.pluto.driver.url.impl.PortalURLImpl
      and
      org.apache.pluto.driver.url.impl.RelativePortalURLImpl

      public String toString() {
      return PortalURLParserImpl.getParser().toString(this);
      }

      Am I just confused as to how this should work, or was this singleton just missed?

      Best,
      Nate

      Nathaniel A. Johnson Voice: 812.855.9905
      Principal Systems Analyst Fax: 812.856.9046
      Systems Integration Team, Indiana University

      1. PLUTO-356.patch
        4 kB
        Elliot Metsger

        Issue Links

          Activity

          Hide
          Elliot Metsger added a comment -

          Nate, can you try applying this patch and see if it works for you? Let me know if you have trouble applying it.

          Show
          Elliot Metsger added a comment - Nate, can you try applying this patch and see if it works for you? Let me know if you have trouble applying it.
          Hide
          Nate Johnson added a comment -

          I will try to test this as soon as I can. We are currently using the 1.1.2 binaries. Will this patch work or would I need to upgrade to head?

          Show
          Nate Johnson added a comment - I will try to test this as soon as I can. We are currently using the 1.1.2 binaries. Will this patch work or would I need to upgrade to head?
          Hide
          Elliot Metsger added a comment -

          PortalURLParser is now provided as an argument to the RelativePortalURLImpl constructor. Fix committed to the pluto-1.1.x branch. Nate if you could confirm that this fixes things for you, it would be appreciated. Thanks!

          Show
          Elliot Metsger added a comment - PortalURLParser is now provided as an argument to the RelativePortalURLImpl constructor. Fix committed to the pluto-1.1.x branch. Nate if you could confirm that this fixes things for you, it would be appreciated. Thanks!
          Hide
          Nate Johnson added a comment -

          I haven't been able to put this into our development code yet, but after talking to Dave at JA-SIG, and finding the correct branch in your version control, I believe this is going to work out just great. Thanks for getting this fix in!

          Show
          Nate Johnson added a comment - I haven't been able to put this into our development code yet, but after talking to Dave at JA-SIG, and finding the correct branch in your version control, I believe this is going to work out just great. Thanks for getting this fix in!
          Hide
          Elliot Metsger added a comment -

          Applied to trunk r554485.

          Show
          Elliot Metsger added a comment - Applied to trunk r554485.
          Hide
          Elliot Metsger added a comment -

          PLUTO-361 reverted part of this patch. Need to add a unit test for PLUTO-356.

          Show
          Elliot Metsger added a comment - PLUTO-361 reverted part of this patch. Need to add a unit test for PLUTO-356 .
          Hide
          Elliot Metsger added a comment -

          Updating fix ver to 1.1.5/2.0.0

          Show
          Elliot Metsger added a comment - Updating fix ver to 1.1.5/2.0.0
          Hide
          Elliot Metsger added a comment -

          Fix committed to 1.1.x branch 609238.

          The 286 merge branch is out of date and this patch can't be easily merged/applied to it.

          Show
          Elliot Metsger added a comment - Fix committed to 1.1.x branch 609238. The 286 merge branch is out of date and this patch can't be easily merged/applied to it.
          Hide
          Elliot Metsger added a comment -

          PLUTO-469 is this issue opened against 2.0.0.

          Show
          Elliot Metsger added a comment - PLUTO-469 is this issue opened against 2.0.0.

            People

            • Assignee:
              Elliot Metsger
              Reporter:
              Nate Johnson
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development