[PLUTO-167] PortletPreferencesImpl.getMap() breaks the spec: PLT 14.1 (xci)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.0-alpha1
• Fix Version/s: 1.1.0-alpha1
• Component/s: portlet container
• Assignee: Unassigned
• Reporter: @deprecated ZHENG Zhong
• Created: 14/Sep/05 02:39
• Updated: 22/Feb/07 04:58
• Resolved: 14/Sep/05 09:17

Description

The portlet spec (xci, SPEC 91, PLT 14.1) states that:

The getMap method returns an immutable Map of String keys and String[] values containing all current preference values. Preferences values must not be modified if the values in the Map are altered.

I added a checkPreferencesValuesNotModified() method in the testsuite class SimplePreferenceTest, to check PLT 14.1. That test failed: In fact, if I changed the values of the string array in the map returned (NOT to put an entry into the map, since that operation is not allowed), the preferences values are changed accordingly.

The bug resides in the class PortletPreferencesImpl. I updated the method getMap() as the following, and then the spec was respected:

public Map getMap() {
Map map = new java.util.HashMap();
Iterator it = preferences.keySet().iterator();
while (it.hasNext())

{ PortletPreference pref = (PortletPreference)preferences.get(it.next()); map.put(pref.getName(), pref.getValues().clone()); // <== Here we clone the string array. }

return Collections.unmodifiableMap(map);
}