Uploaded image for project: 'Pivot'
  1. Pivot
  2. PIVOT-990

MenuPopup can overflow off the top of the window

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.4, 2.1
    • Fix Version/s: 2.1, 2.0.5
    • Component/s: wtk-terra
    • Labels:
      None
    • Environment:
      All

      Description

      If the window / display size is small (either height [usually] or width), a tall or wide MenuPopup will be positioned either off the top or off the left of the window and you cannot see the top/left of the menu. This is particularly a problem with the height because you cannot see the menu items that are positioned outside the window, and so you cannot properly select them.

      The solution is to limit the border size in these cases, so that the Panorama that surrounds the menu list will automatically come into play and allow the menu to be scrolled into view.

      1. 990.patch
        1 kB
        Roger Whitcomb
      2. menu_popup_cut_off.png
        84 kB
        Roger Whitcomb
      3. menu_popup_fixed.png
        102 kB
        Roger Whitcomb

        Activity

        Hide
        rwhitcomb Roger Whitcomb added a comment -

        The "990.patch" file has my proposed solution. Basically just limit the Border size to the display size, and set X/Y to 0. This allows the top/left to be seen and also allows the Panorama to come into play to allow scrolling.

        Show
        rwhitcomb Roger Whitcomb added a comment - The "990.patch" file has my proposed solution. Basically just limit the Border size to the display size, and set X/Y to 0. This allows the top/left to be seen and also allows the Panorama to come into play to allow scrolling.
        Hide
        rwhitcomb Roger Whitcomb added a comment - - edited

        "menu_popup_cut_off.png" shows the MenuPopup running off the top of the display when the window is shorter than the menu itself.

        Show
        rwhitcomb Roger Whitcomb added a comment - - edited "menu_popup_cut_off.png" shows the MenuPopup running off the top of the display when the window is shorter than the menu itself.
        Hide
        rwhitcomb Roger Whitcomb added a comment -

        "menu_popup_fixed.png" shows the state after the patch was applied: the menu is positioned so that the top item is shown, and there is a scroll arrow (Panorama) at the bottom so the rest of the menu can be scrolled into view.

        Show
        rwhitcomb Roger Whitcomb added a comment - "menu_popup_fixed.png" shows the state after the patch was applied: the menu is positioned so that the top item is shown, and there is a scroll arrow (Panorama) at the bottom so the rest of the menu can be scrolled into view.
        Hide
        rwhitcomb Roger Whitcomb added a comment -

        Committed the change in "trunk" (for version 2.1.0):
        Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuPopupSkin.java
        Transmitting file data .
        Committed revision 1756534.

        Merged into "branches/2.0.x":
        Sending .
        Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuPopupSkin.java
        Transmitting file data .
        Committed revision 1756535.

        Show
        rwhitcomb Roger Whitcomb added a comment - Committed the change in "trunk" (for version 2.1.0): Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuPopupSkin.java Transmitting file data . Committed revision 1756534. Merged into "branches/2.0.x": Sending . Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuPopupSkin.java Transmitting file data . Committed revision 1756535.
        Hide
        rwhitcomb Roger Whitcomb added a comment -

        After testing the fail case in our application, I'm satisfied that this issue is fixed.

        Show
        rwhitcomb Roger Whitcomb added a comment - After testing the fail case in our application, I'm satisfied that this issue is fixed.

          People

          • Assignee:
            rwhitcomb Roger Whitcomb
            Reporter:
            rwhitcomb Roger Whitcomb
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development