[PIVOT-987] Different handling of script return values in BXMLSerializer

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.4
• Fix Version/s: 2.1, 2.0.5
• Component/s: core-serialization
• Environment: All
• Assignee: Roger Lee Whitcomb
• Reporter: Josh Highley
• Created: 22/Apr/16 15:38
• Updated: 12/Aug/16 21:09
• Resolved: 12/Aug/16 21:09

Description

In my bxml, I defined a TextInputContentListener method for previewInsertText in script. The method was getting invoked, but my returned Vote seemed to get ignored. Stepping through the code, I found that BXMLSerializer never assigns the result variable and ignores the returned value when the method is specified as an attribute but not when it's a child element. Is there a reason for this, or is this a bug?

I'm using 2.0.4, but the same code is in trunk

BXMLSerializer:

inner class AttributeInvocationHandler, method invoke(Object proxy, Method method, Object[] args)
....
// If the function didn't return a value, return the default
Class<?> returnType = method.getReturnType();
if (returnType == Vote.class)

{ result = Vote.APPROVE; }

else if (returnType == Boolean.TYPE)

{ result = false; }

return result;

inner class ElementInvocationHandler, method invoke(Object proxy, Method method, Object[] args)
.....
// If the function didn't return a value, return the default
if (result == null) {
Class<?> returnType = method.getReturnType();
if (returnType == Vote.class)

{ result = Vote.APPROVE; }

else if (returnType == Boolean.TYPE)

{ result = false; }

}

return result;