Uploaded image for project: 'Pivot'
  1. Pivot
  2. PIVOT-924

Standard handling of exceptions in BXMLSerializer

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.0.3
    • 2.0.4, 2.1
    • core-serialization
    • None

    Description

      We require handling of all uncaught exceptions using standard mechanism (implementing UncaughtExceptionHandler interface on PivotApplication class).
      Similar to recently resolved https://issues.apache.org/jira/browse/PIVOT-916, it is currently not possible also in BXMLSerializer class. To resolve this, I would propose to:

      1) Handle all exception reporting in BXMLSerializer in single protected method to enable overriding this method in BXMLSerializer descendant. I will upload patch for this.

      2) Change scope of static ApplicationContext.handleUncaughtException method to public. This will enable the delegation of exception handling from BXMLSerializer descendants to ApplicationContext. So hacks like this http://svn.codespot.com/a/apache-extras.org/pivot-contrib/trunk/pivot_contrib.util/src/pivot_contrib/util/serializer/InjectingSerializer.java wont be required anymore .

      Please let me know, if someone can see more elegant solution.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            rwhitcomb Roger Lee Whitcomb
            kaja78 Karel Hübl
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment